lkml.org 
[lkml]   [2008]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Add pca9532 platform data for Thecus N2100
Riku Voipio writes:
> Thecus N2100 has leds and a buzzer attached to a pca9532
> controller. Attach the driver to the i2c bus and define
> the pca9532 pin coniguration for this platform in n2100_leds.
>
> With this patch, support for N2100 should be complete in mainline
> Linux.
>
> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> ---
> arch/arm/mach-iop32x/n2100.c | 52 ++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 52 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-iop32x/n2100.c b/arch/arm/mach-iop32x/n2100.c
> index bc91d6e..029d234 100644
> --- a/arch/arm/mach-iop32x/n2100.c
> +++ b/arch/arm/mach-iop32x/n2100.c
> @@ -17,6 +17,7 @@
> #include <linux/mm.h>
> #include <linux/init.h>
> #include <linux/f75375s.h>
> +#include <linux/leds-pca9532.h>
> #include <linux/delay.h>
> #include <linux/kernel.h>
> #include <linux/pci.h>
> @@ -206,6 +207,53 @@ static struct f75375s_platform_data n2100_f75375s = {
> .pwm_enable = { 0, 0 },
> };
>
> +static struct pca9532_platform_data n2100_leds = {
> + .leds = {
> + { .name = "n2100:red:satafail0",
> + .state = PCA9532_OFF,
> + .type = PCA9532_TYPE_LED,
> + },
> + { .name = "n2100:red:satafail1",
> + .state = PCA9532_OFF,
> + .type = PCA9532_TYPE_LED,
> + },
> + { .name = "n2100:blue:usb",
> + .state = PCA9532_OFF,
> + .type = PCA9532_TYPE_LED,
> + },
> + { .type = PCA9532_TYPE_NONE },
> +
> + { .type = PCA9532_TYPE_NONE },
> + { .type = PCA9532_TYPE_NONE },
> + { .type = PCA9532_TYPE_NONE },
> + { .name = "n2100:red:usb",
> + .state = PCA9532_OFF,
> + .type = PCA9532_TYPE_LED,
> + },
> +
> + { .type = PCA9532_TYPE_NONE }, /* power OFF gpio */
> + { .type = PCA9532_TYPE_NONE }, /* reset gpio */
> + { .type = PCA9532_TYPE_NONE },
> + { .type = PCA9532_TYPE_NONE },
> +
> + { .type = PCA9532_TYPE_NONE },
> + { .name = "n2100:orange:system",
> + .state = PCA9532_OFF,
> + .type = PCA9532_TYPE_LED,
> + },
> + { .name = "n2100:red:system",
> + .state = PCA9532_OFF,
> + .type = PCA9532_TYPE_LED,
> + },
> + { .name = "N2100 beeper" ,
> + .state = PCA9532_OFF,
> + .type = PCA9532_TYPE_N2100_BEEP,
> + },
> + },
> + .psc = { 0, 0 },
> + .pwm = { 0, 0 },
> +};
> +

This .leds field looks like an array where an item's position
is significant. If this is the case, initialisers should use
the "[N] = { ... }," notation, IMO.
Also, intendation in the .leds initialiser is wrong.

Apart from that, thank you for completing the n2100 hw support.

/Mikael


\
 
 \ /
  Last update: 2008-04-30 09:53    [from the cache]
©2003-2011 Jasper Spaans