Messages in this thread | | | Subject | Re: [RFC][PATCH 5/5] Add a Signal Control Group Subsystem | From | Matt Helsley <> | Date | Wed, 30 Apr 2008 00:48:34 -0700 |
| |
On Thu, 2008-04-24 at 14:30 -0500, Paul Jackson wrote: > > +static struct cftype kill_file = { > > + .name = "kill", > > The name "kill" seems ambiguous to me. It suggests that any write > will send some default signal (TERM or KILL?) to all tasks in the > cgroup, rather like the 'killall' command. > > I'm guessing that more people, on seeing this file in a cgroup > directory, will guess correctly what it does if it were named > "signal" or "send_signal" or some such.
OK, I renamed it signal.send and replaced all uses of "kill" in the code to indicate that we're actually sending a signal -- not "KILL"ing things :).
Cheers, -Matt
| |