Messages in this thread | | | Date | Wed, 30 Apr 2008 08:11:08 +0100 | From | "Jaime Velasco" <> | Subject | Re: [patch] video: fix build bugs in drivers/media/video/stk-webcam.c |
| |
2008/4/29 Ingo Molnar <mingo@elte.hu>: > > x86.git randconfig testing found these build bugs in current -git: > > drivers/media/video/stk-webcam.c: In function 'stk_create_sysfs_files': > drivers/media/video/stk-webcam.c:340: error: implicit declaration of function 'video_device_create_file' > drivers/media/video/stk-webcam.c: In function 'stk_remove_sysfs_files': > [...] > drivers/media/video/stk-webcam.c: In function 'v4l_stk_mmap': > drivers/media/video/stk-webcam.c:846: error: 'VM_WRITE' undeclared (first use in this function) > [...] > > config at: > > http://redhat.com/~mingo/misc/config-Tue_Apr_29_15_00_47_CEST_2008.bad > > the reason was a missing include file, and a dependency on a deprecated > (but still in use) VIDEO_V4L1_COMPAT API. > > Signed-off-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Jaime Velasco Juan <jsagarribay@gmail.com>
For the record, this bug was found in march, but it seems I forgot to CC: the patch to Mauro, Sorry about that.
http://marc.info/?l=linux-video&m=120594964524615&w=2
Regards, Jaime
> --- > drivers/media/video/Kconfig | 1 + > drivers/media/video/stk-webcam.c | 1 + > 2 files changed, 2 insertions(+) > > Index: linux/drivers/media/video/Kconfig > =================================================================== > --- linux.orig/drivers/media/video/Kconfig > +++ linux/drivers/media/video/Kconfig > @@ -835,6 +835,7 @@ config USB_ZR364XX > config USB_STKWEBCAM > tristate "USB Syntek DC1125 Camera support" > depends on VIDEO_V4L2 && EXPERIMENTAL > + select VIDEO_V4L1_COMPAT > ---help--- > Say Y here if you want to use this type of camera. > Supported devices are typically found in some Asus laptops, > Index: linux/drivers/media/video/stk-webcam.c > =================================================================== > --- linux.orig/drivers/media/video/stk-webcam.c > +++ linux/drivers/media/video/stk-webcam.c > @@ -28,6 +28,7 @@ > #include <linux/errno.h> > #include <linux/slab.h> > #include <linux/kref.h> > +#include <linux/mm.h> > > #include <linux/usb.h> > #include <linux/vmalloc.h> >
| |