lkml.org 
[lkml]   [2008]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] sound/video: fix sound/i2c/other/tea575x-tuner.c build bug
At Tue, 29 Apr 2008 22:46:43 +0200,
Ingo Molnar wrote:
>
>
> fix build failure triggered on latest -git by this config:
>
> http://redhat.com/~mingo/misc/config-Tue_Apr_29_22_33_36_CEST_2008.bad
>
> sound/i2c/other/tea575x-tuner.c: In function 'snd_tea575x_ioctl':
> sound/i2c/other/tea575x-tuner.c:95: error: 'VIDIOCGCAP' undeclared (first use in this function)
> sound/i2c/other/tea575x-tuner.c:95: error: (Each undeclared identifier is reported only once
> sound/i2c/other/tea575x-tuner.c:95: error: for each function it appears in.)
> sound/i2c/other/tea575x-tuner.c:97: error: storage size of 'v' isn't known
>
> the CONFIG_SND_FM801_TEA575X code still depends on VIDEO_V4L1_COMPAT
> APIs.

I'm afraid that the select of VIDEO_V4L1 from fm801 makes the things
messy enough. And more select, eh... IMO, this should be rather
depend on VIDEO_V4L1.

But, there is a dependency chain problem among snd-fm801,
snd-fm801-tea575x and V4L layer. I'll check it.


Takashi

>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
> sound/pci/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux/sound/pci/Kconfig
> ===================================================================
> --- linux.orig/sound/pci/Kconfig
> +++ linux/sound/pci/Kconfig
> @@ -529,6 +529,7 @@ config SND_FM801_TEA575X
> depends on SND_FM801_TEA575X_BOOL
> default SND_FM801
> select VIDEO_V4L1
> + select VIDEO_V4L1_COMPAT
> select VIDEO_DEV
>
> config SND_HDA_INTEL
>


\
 
 \ /
  Last update: 2008-04-30 12:45    [W:0.058 / U:1.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site