Messages in this thread | | | Subject | Re: [PATCH 4 of 6] hotplug-memory: use common online_page | From | Dave Hansen <> | Date | Thu, 03 Apr 2008 18:00:05 -0700 |
| |
On Thu, 2008-04-03 at 17:56 -0700, Jeremy Fitzhardinge wrote: > Dave Hansen wrote: > > This is OK, but I do think the __weak stuff can make it a bit > > counter-intuitive to track down which version is actually getting used. > > Are there any people the currently override that __weak? > > > > If not, we should probably just kill it. > > Yes, x86-32 has a different implementation.
I guess we could just make the copies conditional on CONFIG_HIGHMEM and define them both next to each other. It's really a highmem thing more than a per-arch thing.
-- Dave
| |