![]() | ||||||||||
Messages in this thread |
just nitpicks ;) On Thu, 03 Apr 2008 11:29:01 +0530 Balbir Singh <balbir@linux.vnet.ibm.com> wrote: > #define mm_match_cgroup(mm, cgroup) \ > - ((cgroup) == rcu_dereference((mm)->mem_cgroup)) > + ((cgroup) == mem_cgroup_from_task((mm)->owner)) > After this patch, above should be == #define mm_match_cgroup_css(mm, css, subsys_id) ((css) == task_subsys_state((mm)->owner, subsys_id) == This generic macro may be good for your purpose. > #endif > diff -puN init/Kconfig~memory-controller-add-mm-owner init/Kconfig > --- linux-2.6.25-rc8/init/Kconfig~memory-controller-add-mm-owner 2008-04-03 10:08:23.000000000 +0530 > +++ linux-2.6.25-rc8-balbir/init/Kconfig 2008-04-03 10:08:23.000000000 +0530 > @@ -371,9 +371,21 @@ config RESOURCE_COUNTERS > infrastructure that works with cgroups > depends on CGROUPS > > +config MM_OWNER > + bool "Enable ownership of mm structure" > + help > + This option enables mm_struct's to have an owner. The advantage > + of this approach is that it allows for several independent memory > + based cgorup controllers to co-exist independently without too > + much space overhead Above is an explanation for this patch. More simple text is better... How about == This is necessary for some cgroup subsystem related to memory management. == > +> + This feature adds fork/exit overhead. So enable this only if > + you need resource controllers> + > config CGROUP_MEM_RES_CTLR > bool "Memory Resource Controller for Control Groups" > depends on CGROUPS && RESOURCE_COUNTERS > + select MM_OWNER I don't like "select"....this should be depends on CGROUPS && RESOURCE_COUNTERS && MM_OWNER Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | |||||||||
| Last update: 2008-04-03 08:39 [from the cache] ©2003-2008 | ||||||||||