lkml.org 
[lkml]   [2008]   [Apr]   [29]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 29 Apr 2008 11:06:31 +0300
FromAdrian Bunk <>
SubjectRe: [2.6 patch] fs/block_dev.c:I_BDEV() mustn't be inline
On Mon, Apr 28, 2008 at 05:41:11PM -0700, Linus Torvalds wrote:
>...
> > -inline struct block_device *I_BDEV(struct inode *inode)
> > +struct block_device *I_BDEV(struct inode *inode)
> >  {
> >  	return &BDEV_I(inode)->bdev;
> >  }
> 
> There is NO WAY IN HELL this function shouldn't be inlined,
>...

Then CONFIG_OPTIMIZE_INLINING already broke it in your tree.

> 			Linus

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



\
 
 \ /
  Last update: 2008-04-29 10:09    [from the cache]
©2003-2008