lkml.org 
[lkml]   [2008]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] USB: sierra: add support for Onda H600/Zte MF330
    Kevin Lloyd wrote:
    > Hi Tim,
    >
    > The sierra device driver is really trying to focus on Sierra vendor specific features and it might not be the best approach to add a Onda/Zte device here. Might I suggest the option driver? That is where the other Onda/Zte devices are stored.
    >
    > -Kevin
    >
    > -----Original Message-----
    > From: Tim Gardner [mailto:timg@tpi.com]
    > Sent: Tuesday, April 29, 2008 12:47 PM
    > To: Kevin Lloyd
    > Cc: linux-kernel@vger.kernel.org; tim.gardner@canonical.com
    > Subject: [PATCH] USB: sierra: add support for Onda H600/Zte MF330
    >
    > From: Bruno Redondi <bruno.redondi@altarisoluzione.com>
    > Date: Fri, 1 Feb 2008 15:16:52 -0800
    > Subject: [PATCH] USB: sierra: add support for Onda H600/Zte MF330 datacard to USB Driver for
    > Sierra Wireless
    >
    > Added support for Onda H600/Zte MF330 GPRS/UMTS/HSDPA datacard
    >
    > Signed-off-by: Bruno Redondi <bruno.redondi@altarisoluzione.com>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    > Signed-off-by: Amit Kucheria <amit.kucheria@ubuntu.com>
    > Cc: stable@kernel.org
    > ---
    > drivers/usb/serial/sierra.c | 1 +
    > 1 files changed, 1 insertions(+), 0 deletions(-)
    >
    > diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
    > index ed67881..da5a519 100644
    > --- a/drivers/usb/serial/sierra.c
    > +++ b/drivers/usb/serial/sierra.c
    > @@ -179,6 +179,7 @@ static struct usb_device_id id_table [] = {
    >
    > { USB_DEVICE(0x1199, 0x0112), .driver_info = DEVICE_1_PORT }, /* Sierra Wireless AirCard 580 */
    > { USB_DEVICE(0x0F3D, 0x0112), .driver_info = DEVICE_1_PORT }, /* Airprime/Sierra PC 5220 */
    > + { USB_DEVICE(0x05C6, 0x6613), .driver_info = DEVICE_1_PORT }, /* Onda H600/ZTE MF330 */
    >
    > { USB_DEVICE(0x1199, 0x0FFF), .driver_info = DEVICE_INSTALLER},
    > { }
    > --
    > 1.5.4.3
    >
    >

    You are correct. In fact, it is already in drivers/usb/serial/option.c
    using QUALCOMM_VENDOR_ID.

    rtg
    --
    Tim Gardner tim.gardner@ubuntu.com


    \
     
     \ /
      Last update: 2008-04-29 22:53    [W:0.027 / U:30.316 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site