[lkml]   [2008]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[09/12] USB: remove broken usb-serial num_endpoints check
    2.6.24-stable review patch.  If anyone has any objections, please let us


    From: Greg Kroah-Hartman <>

    commit: 07c3b1a1001614442c665570942a3107a722c314

    The num_interrupt_in, num_bulk_in, and other checks in the usb-serial
    code are just wrong, there are too many different devices out there with
    different numbers of endpoints. We need to just be sticking with the
    device ids instead of trying to catch this kind of thing. It broke too
    many different devices.

    This fixes a large number of usb-serial devices to get them working
    properly again.

    Cc: Oliver Neukum <>
    Signed-off-by: Greg Kroah-Hartman <>

    drivers/usb/serial/usb-serial.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/usb/serial/usb-serial.c
    +++ b/drivers/usb/serial/usb-serial.c
    @@ -844,6 +844,7 @@ int usb_serial_probe(struct usb_interfac
    serial->num_interrupt_in = num_interrupt_in;
    serial->num_interrupt_out = num_interrupt_out;

    +#if 0
    /* check that the device meets the driver's requirements */
    if ((type->num_interrupt_in != NUM_DONT_CARE &&
    type->num_interrupt_in != num_interrupt_in)
    @@ -857,6 +858,7 @@ int usb_serial_probe(struct usb_interfac
    return -EIO;

    /* found all that we need */
    dev_info(&interface->dev, "%s converter detected\n",

     \ /
      Last update: 2008-04-29 20:59    [W:0.020 / U:71.172 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site