lkml.org 
[lkml]   [2008]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[35/37] alpha: unbreak OSF/1 (a.out) binaries
    2.6.25-stable review patch.  If anyone has any objections, please let us
    know.

    ------------------
    From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
    commit 2444e56b0c08e6f3e3877583841a1213e3263d98 upstream


    OSF/1 brk(2) was broken by following one-liner in sys_brk()
    (commit 4cc6028d4040f95cdb590a87db478b42b8be0508):

    - if (brk < mm->end_code)
    + if (brk < mm->start_brk)
    goto out;
    The problem is that osf_set_program_attributes()
    does update mm->end_code, but not mm->start_brk,
    which still contains inappropriate value left from
    binary loader, so brk() always fails.

    Signed-off-by: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    arch/alpha/kernel/osf_sys.c | 1 +
    1 file changed, 1 insertion(+)
    --- a/arch/alpha/kernel/osf_sys.c
    +++ b/arch/alpha/kernel/osf_sys.c
    @@ -75,6 +75,7 @@ osf_set_program_attributes(unsigned long
    lock_kernel();
    mm = current->mm;
    mm->end_code = bss_start + bss_len;
    + mm->start_brk = bss_start + bss_len;
    mm->brk = bss_start + bss_len;
    #if 0
    printk("set_program_attributes(%lx %lx %lx %lx)\n",
    --


    \
     
     \ /
      Last update: 2008-04-29 19:37    [from the cache]
    ©2003-2014 Jasper Spaans. Advertise on this site