lkml.org 
[lkml]   [2008]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[22/37] ssb: Fix all-ones boardflags

    2.6.25-stable review patch. If anyone has any objections, please let us
    know.

    ------------------
    From: Larry Finger <Larry.Finger@lwfinger.net>
    commit 4503183aa32e6886400d82282292934fa64a81b0 upstream

    In the SSB SPROM a field set to all ones means the value
    is not defined in the SPROM.
    In case of the boardflags, we need to set them to zero
    to avoid confusing drivers. Drivers will only check the
    flags by ANDing.


    Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: Gabor Stefanik <netrolller.3d@gmail.com>
    Signed-off-by: Michael Buesch <mb@bu3sch.de>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/ssb/pci.c | 5 +++++
    1 file changed, 5 insertions(+)
    --- a/drivers/ssb/pci.c
    +++ b/drivers/ssb/pci.c
    @@ -482,6 +482,11 @@ static int sprom_extract(struct ssb_bus
    goto unsupported;
    }

    + if (out->boardflags_lo == 0xFFFF)
    + out->boardflags_lo = 0; /* per specs */
    + if (out->boardflags_hi == 0xFFFF)
    + out->boardflags_hi = 0; /* per specs */
    +
    return 0;
    unsupported:
    ssb_printk(KERN_WARNING PFX "Unsupported SPROM revision %d "
    --


    \
     
     \ /
      Last update: 2008-04-29 19:33    [from the cache]
    ©2003-2014 Jasper Spaans. Advertise on this site