lkml.org 
[lkml]   [2008]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARCH: Fix 32-bit x86 MSI-X allocation leakage

* Waskiewicz Jr, Peter P <peter.p.waskiewicz.jr@intel.com> wrote:

> > * PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com> wrote:
> >
> > > This bug was introduced in the 2.6.24 i386/x86_64 tree merge, [...]
> >
> > that's wrong, that code was there in v2.6.23 too - and it wasnt
> > touched in the unification. Why do you think it was introduced in
> > the i386/x86_64 tree merge?
>
> 2.6.23.17 didn't have the used_vectors bitmap. The first time I could
> find it used was in 2.6.24. Where was the code existing in 2.6.23?
> The addition may have not been part of the merge, but it was
> definitely introduced in the same timeframe, meaning the 2.6.24
> release timeframe.

that change came in via lguest (commit dbeb2be2), not the 32-bit/64-bit
x86 unification. Lguest is a new feature in 2.6.24 and this side-effect
of it was not known until you fixed it - thanks for that!

So i was just splitting hairs over your statement that it was due to the
unification :-)

Ingo


\
 
 \ /
  Last update: 2008-04-29 17:17    [W:0.063 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site