Messages in this thread | | | Date | Tue, 29 Apr 2008 16:20:39 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] bitops: remove "optimizations" |
| |
* David Miller <davem@davemloft.net> wrote:
> From: David Miller <davem@davemloft.net> > Date: Tue, 29 Apr 2008 03:03:32 -0700 (PDT) > > > From: Thomas Gleixner <tglx@linutronix.de> > > Date: Tue, 29 Apr 2008 12:01:02 +0200 (CEST) > > > > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > > > > Acked-by: David S. Miller <davem@davemloft.net> > > Ironically, I just bisected sparc64 bootup failures to the following > changeset. It's very late here, and I haven't looked into the > details, but it seems to wedge in free_area_init_nodes() on a non-NUMA > system with CONFIG_NUMA disabled.
hm. I guess the next thing you plan to check is whether Thomas's patch fixes it?
> Isn't it funny that this optimization not only was useless, but also > broke things. :-/
yeah and sorry :-/ It would still be nice to understand why this happened, it looks like a weird (and unexpected) interaction.
Ingo
| |