Messages in this thread Patch in this message | | | Date | Tue, 29 Apr 2008 16:18:08 +0200 (MEST) | From | Julia Lawall <> | Subject | Re: [revised PATCH] crypto: Correct kzalloc error test |
| |
From: Julia Lawall <julia@diku.dk>
Normally, kzalloc returns NULL or a valid pointer value, not a value to be tested using IS_ERR.
Signed-off-by: Julia Lawall <julia@diku.dk> --- diff -u -p a/crypto/cryptd.c b/crypto/cryptd.c --- a/crypto/cryptd.c 2008-04-16 13:27:56.000000000 +0200 +++ b/crypto/cryptd.c 2008-04-29 16:13:10.000000000 +0200 @@ -190,8 +190,10 @@ static struct crypto_instance *cryptd_al int err;
inst = kzalloc(sizeof(*inst) + sizeof(*ctx), GFP_KERNEL); - if (IS_ERR(inst)) + if (!inst) { + inst = ERR_PTR(-ENOMEM); goto out; + }
err = -ENAMETOOLONG; if (snprintf(inst->alg.cra_driver_name, CRYPTO_MAX_ALG_NAME,
| |