lkml.org 
[lkml]   [2008]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.25: pmac_newworld undefined
    On Mon, Apr 28, 2008 at 09:33:24PM +0200, Sam Ravnborg wrote:
    > On Mon, Apr 28, 2008 at 02:20:44PM +1000, Tony Breeds wrote:
    > > On Sun, Apr 27, 2008 at 08:03:46PM +0200, Christian Kujau wrote:
    > > > Hi,
    > > >
    > > > the build failure reported[0] by Kamalesh back in 01/2008 is still
    > > > present in today's 2.6.25-git with CONFIG_NVRAM=m (instead of =y):
    > > >
    > > > Building modules, stage 2.
    > > > MODPOST 72 modules
    > > > ERROR: "pmac_newworld" [arch/powerpc/platforms/powermac/nvram.ko] undefined!
    > > > ERROR: "__alloc_bootmem" [arch/powerpc/platforms/powermac/nvram.ko]
    > > > undefined!
    > > > make[1]: *** [__modpost] Error 1
    > >
    > > Yeah that isn't really surprising. Essentially
    > > arch/powerpc/platforms/powermac/nvram.c must be builtin (not modular)
    > > but CONFIG_NVRAM is tristate, and your .config has CONFIG_NVRAM=m.
    > >
    > > We can probably "fix" this by adding another config config symbol and
    > > "selecting" that from CONFIG_NVRAM. Then using this new symbol in
    > > arch/powerpc/platforms/powermac/*
    > >
    > > so I think with we need is:
    > > config NVRAM
    > > bool "..." if PPC32
    > > tristate "..." if !PPC32
    > > ...
    > > ...
    > >
    > > Sam is there some way to achieve that or should we just create an
    > > secondary symbol?
    >
    > In the Makefile you could just do a:
    >
    > obj-$(CONFIG_NVRAM:m=y) += nvram.o
    >
    > Then you would force nvram to be build-in.
    > That looks simpler than messing with Kconfig in this case.

    You miss that this is only true on powerpc.

    And for such issues Kconfig anyway is the right place - assume how your
    solution would break if NVRAM would some day select or depend on some
    helper code.

    > Sam

    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed



    \
     
     \ /
      Last update: 2008-04-29 15:39    [W:2.583 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site