lkml.org 
[lkml]   [2008]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch/rfc 2.6.25-git] gpio: sysfs interface
On Mon, 28 Apr 2008 16:28:13 -0700 David Brownell <david-b@pacbell.net> wrote:

> > If we had a strcmp() variant which treats a \n in the first arg as a \0
> > the above would become
> >
> > if (sysfs_streq(buf, "high"))
> > status = gpio_direction_output(gpio, 1);
> > else if (sysfs_streq(buf, "out") || sysfs_streq(buf, "low"))
> > status = gpio_direction_output(gpio, 0);
> > else if (sysfs_streq(buf, "in"))
> > status = gpio_direction_input(gpio);
>
> That would indeed be better. Maybe I should whip up a sysfs
> patch adding that, and have this depend on that patch. (I've
> CC'd Greg in case he has comments on that...)

Yes, it would be a standalone patch. The sort which generates oceans of
useful feedback ;) The sort which also generates hundreds of
use-new-toy-to-clean-up-old-code patches for me to merge :(

> Alternatively: strict_streq(), analogy to strict_strto*()?

Yeah, I couldn't think of a decent name. I do think it should return true
on finding a match so callers don't need to use ! or ==0. So its name
shouldn't look anything like "strcmp".



\
 
 \ /
  Last update: 2008-04-29 04:59    [from the cache]
©2003-2011 Jasper Spaans