lkml.org 
[lkml]   [2008]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 23/55] PNP: remove pnp_resource_table from internal pnp_clean_resource_table interface
    This changes pnp_clean_resource_table() to take a pnp_dev pointer
    rather than a pnp_resource_table pointer. This reduces the visibility
    of pnp_resource_table and removes an opportunity for error in the
    caller.

    Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
    Acked-By: Rene Herman <rene.herman@gmail.com>

    Index: work10/drivers/pnp/manager.c
    ===================================================================
    --- work10.orig/drivers/pnp/manager.c 2008-04-28 16:09:22.000000000 -0600
    +++ work10/drivers/pnp/manager.c 2008-04-28 16:09:23.000000000 -0600
    @@ -281,8 +281,9 @@
    * pnp_clean_resources - clears resources that were not manually set
    * @res: the resources to clean
    */
    -static void pnp_clean_resource_table(struct pnp_resource_table *res)
    +static void pnp_clean_resource_table(struct pnp_dev *dev)
    {
    + struct pnp_resource_table *res = &dev->res;
    int idx;

    for (idx = 0; idx < PNP_MAX_IRQ; idx++) {
    @@ -339,7 +340,7 @@

    dbg_pnp_show_resources(dev, "before pnp_assign_resources");
    mutex_lock(&pnp_res_mutex);
    - pnp_clean_resource_table(&dev->res); /* start with a fresh slate */
    + pnp_clean_resource_table(dev);
    if (dev->independent) {
    dev_dbg(&dev->dev, "assigning independent options\n");
    port = dev->independent->port;
    @@ -415,7 +416,7 @@
    return 1;

    fail:
    - pnp_clean_resource_table(&dev->res);
    + pnp_clean_resource_table(dev);
    mutex_unlock(&pnp_res_mutex);
    dbg_pnp_show_resources(dev, "after pnp_assign_resources (failed)");
    return 0;
    @@ -595,7 +596,7 @@

    /* release the resources so that other devices can use them */
    mutex_lock(&pnp_res_mutex);
    - pnp_clean_resource_table(&dev->res);
    + pnp_clean_resource_table(dev);
    mutex_unlock(&pnp_res_mutex);

    return 0;
    --


    \
     
     \ /
      Last update: 2008-04-29 00:53    [W:0.025 / U:32.112 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site