lkml.org 
[lkml]   [2008]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/19] UML - hppfs fixes
On Sat, Apr 26, 2008 at 04:31:32PM +0800, WANG Cong wrote:
> > - copy_to_user(buf, &data->contents[off], count);
> > - *ppos += count;
> > + rem = copy_to_user(buf, &data->contents[off], count);
> > + *ppos += count - rem;
> > + if (rem > 0)
> > + return -EFAULT;
>
>
> Could you please explain why check 'rem' after using it here?

Because I'm an idiot. Will fix.

> > static int hppfs_open(struct inode *inode, struct file *file)
> > {
> > struct hppfs_private *data;
> > - struct dentry *proc_dentry;
> > struct vfsmount *proc_mnt;
> > + struct dentry *proc_dentry;
>
> And what does this kind of change mean?

It means I culdn't make up my mind. I first got rid of the dentrys,
then put them back, but in a different place.

Jeff

--
Work email - jdike at linux dot intel dot com


\
 
 \ /
  Last update: 2008-04-28 17:19    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site