lkml.org 
[lkml]   [2008]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] sched: missing locking in sched_domains code

    * Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

    > > version 42. Please feel free to change the comment if you think it could
    > > be better :)
    >
    > I don't believe this... version 43 ;) I forgot to add the lock in
    > sched_init_smp(). Not that it would really matter, but it should be
    > there to avoid (even more) confusion.

    hey i just had to iterate it to version 44.

    this bit:

    > -/* doms_cur_mutex serializes access to doms_cur[] array */
    > -static DEFINE_MUTEX(doms_cur_mutex);
    > +/* sched_domains_mutex serializes calls to arch_init_sched_domains,
    > + * detach_destroy_domains and partition_sched_domains.
    > + */
    > +static DEFINE_MUTEX(sched_domains_mutex);

    was inside an #ifdef section ;-)

    Ingo


    \
     
     \ /
      Last update: 2008-04-28 15:17    [W:0.024 / U:1.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site