lkml.org 
[lkml]   [2008]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] x86, voyager: fix ioremap_nocache()

* James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

> > request_resource(&iomem_resource, &res);
> > voyager_SUS = (struct voyager_SUS *)
> > - ioremap(addr, 0x400);
> > + ioremap_cache(addr, 0x400);
>
> Actually, no ... wrong ioremap. That one is the SUS clickmap remap,
> which is irrelevant whether it's cached or not. The QIC cacheline area
> is the next one below it.

yes, but i assumed that since you had all cached ioremaps before, you
might wanted it for all of the devices in voyager_cat.c (or at least it
wouldnt hurt). Btw., the QIC ioremap i changed in my patch too, just in
case you didnt notice:

> > - qic_addr = (unsigned long)ioremap(qic_addr, 0x400);
> > + qic_addr = (unsigned long)ioremap_cache(qic_addr, 0x400);

so my patch too should do the trick.

Ingo


\
 
 \ /
  Last update: 2008-04-28 00:45    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site