lkml.org 
[lkml]   [2008]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] x86, voyager: fix ioremap_nocache()
On Sun, Apr 27, 2008 at 06:05:59PM -0400, James Bottomley wrote:
> > Index: linux-x86.q/arch/x86/mach-voyager/voyager_cat.c
> > ===================================================================
> > --- linux-x86.q.orig/arch/x86/mach-voyager/voyager_cat.c
> > +++ linux-x86.q/arch/x86/mach-voyager/voyager_cat.c
> > @@ -602,7 +602,7 @@ void __init voyager_cat_init(void)
> >
> > request_resource(&iomem_resource, &res);
> > voyager_SUS = (struct voyager_SUS *)
> > - ioremap(addr, 0x400);
> > + ioremap_cache(addr, 0x400);
>
> Actually, no ... wrong ioremap. That one is the SUS clickmap remap,
> which is irrelevant whether it's cached or not. The QIC cacheline area
> is the next one below it.
>
> I've already got the actual patch (with a nice explanation) in the
> voyager tree. I'll send them all out to the mailing list shortly; I'm
> just trying to chase down a problem with TSCs before the voyager tree is
> ready.

James,

whatever the fix, please add a comment on the sensible line above so
that the same error does not happen again. Code must be readable without
comments, but magic choices must be commented if there's an underlying
reason.

Thanks,
Willy



\
 
 \ /
  Last update: 2008-04-28 00:39    [W:0.100 / U:0.864 seconds]
©2003-2014 Jasper Spaans. Advertise on this site