Messages in this thread |  | | | From | Dmitry Torokhov <> | | Subject | Re: [patch] pcspkr: fix dependancies | | Date | Sat, 26 Apr 2008 19:18:14 -0400 |
Hi Stas,
On Saturday 26 April 2008, Stas Sergeev wrote:
> Hello.
>
> linux-2.6.25 has the strange dependancies
> for pc-speaker, which prevents snd-pcsp
> from working.
> Namely, the platform device (created in
> arch/x86/kernel/pcspeaker.c) depends on
> the platform driver (CONFIG_INPUT_PCSPKR).
> I wonder if it is a good practice to make
> the platform device to depend on the driver,
> I guess it is not.
>
> The attached patch reverses that.
> It adds the config option for the pcspkr
> platform device and makes the platform
> drivers to depend on that.
> This allows snd-pcsp to work at least in
> some configurations.
>
No, not another config option please. Either make pcspkr platform
device be created unconditionally or if either pcspkr or snd-pcsp
is selected.
--
Dmitry
|  |