lkml.org 
[lkml]   [2008]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch] pcspkr: fix dependancies
    Date
    Hi Stas,

    On Saturday 26 April 2008, Stas Sergeev wrote:
    > Hello.
    >
    > linux-2.6.25 has the strange dependancies
    > for pc-speaker, which prevents snd-pcsp
    > from working.
    > Namely, the platform device (created in
    > arch/x86/kernel/pcspeaker.c) depends on
    > the platform driver (CONFIG_INPUT_PCSPKR).
    > I wonder if it is a good practice to make
    > the platform device to depend on the driver,
    > I guess it is not.
    >
    > The attached patch reverses that.
    > It adds the config option for the pcspkr
    > platform device and makes the platform
    > drivers to depend on that.
    > This allows snd-pcsp to work at least in
    > some configurations.
    >

    No, not another config option please. Either make pcspkr platform
    device be created unconditionally or if either pcspkr or snd-pcsp
    is selected.

    --
    Dmitry


    \
     
     \ /
      Last update: 2008-04-27 01:21    [W:0.024 / U:239.952 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site