Messages in this thread | | | Date | Sat, 26 Apr 2008 09:16:52 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH] 2.6.25-git7 - Kconfig Cleanup |
| |
On Sat, 26 Apr 2008 01:17:33 -0500 Matt LaPlante wrote:
> On Fri, 25 Apr 2008 21:50:37 -0700 > Randy Dunlap <randy.dunlap@oracle.com> wrote: > > > On Fri, 25 Apr 2008 23:28:48 -0500 Matt LaPlante wrote: > > > > > Fix misc small typos/grammar in Kconfigs for 2.6.25-git7. > > > > > > Signed-off-by: Matt LaPlante <kernel1@cyberdogtech.com> > > > -- > > > > > > diff -ru a/arch/cris/arch-v32/Kconfig b/arch/cris/arch-v32/Kconfig > > > --- a/arch/cris/arch-v32/Kconfig 2008-04-16 21:49:44.000000000 -0500 > > > +++ b/arch/cris/arch-v32/Kconfig 2008-04-25 22:13:14.000000000 -0500 > > > @@ -27,8 +27,8 @@ > > > bool "Use one LED group" > > > help > > > Select this if you want one Ethernet LED group. This LED group > > > - can be used for one or more Ethernet interfaces. However, it is > > > - recomended that each Ethernet interface use a dedicated LED group. > > > + can be used for one or more Ethernet interfaces, however it is > > > > That comma creates a run-on sentence. Period was better. > > My problem is the second sentence starting with "however." Although it's not technically breaking any rules, writing style guides generally advise against beginning sentences with it... and on a more basic level, I really dislike the way it reads in this case.
I didn't have a problem with that.
> May I suggest one of: > > - This LED group can be used for one or more Ethernet interfaces, however it is recommended that each interface use a dedicated LED group.
Bad sentence grammar.
> - This LED group can be used for one or more Ethernet interfaces. It is still recommended that each interface use a dedicated LED group, however.
Inverting the order to put the "however" at the end doesn't help IMO.
> - This LED group can be used for one or more Ethernet interfaces. (But it is recommended that each interface use a dedicated LED group.)
- This LED group can be used for one or more Ethernet interfaces, but it is recommended that each interface use a dedicated LED group.
?
> > > > Other than that, looks good. Thanks. > > > > > + recommended that each Ethernet interface use a dedicated LED group. > > > > > > config ETRAX_NBR_LED_GRP_TWO > > > bool "Use two LED groups"
--- ~Randy
| |