lkml.org 
[lkml]   [2008]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 12/54] PNPACPI: pnpacpi_encode_ext_irq() wrongly set "irq" instead of "extended_irq"
    pnpacpi_encode_ext_irq() should set resource->data.extended_irq, not
    resource->data.irq.

    This has been wrong since at least 2.6.12. I haven't seen any bug
    reports, but it's clearly incorrect.

    Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>

    Index: work10/drivers/pnp/pnpacpi/rsparser.c
    ===================================================================
    --- work10.orig/drivers/pnp/pnpacpi/rsparser.c 2008-04-25 11:12:17.000000000 -0600
    +++ work10/drivers/pnp/pnpacpi/rsparser.c 2008-04-25 11:14:52.000000000 -0600
    @@ -820,9 +820,9 @@
    resource->data.extended_irq.triggering = triggering;
    resource->data.extended_irq.polarity = polarity;
    if (triggering == ACPI_EDGE_SENSITIVE)
    - resource->data.irq.sharable = ACPI_EXCLUSIVE;
    + resource->data.extended_irq.sharable = ACPI_EXCLUSIVE;
    else
    - resource->data.irq.sharable = ACPI_SHARED;
    + resource->data.extended_irq.sharable = ACPI_SHARED;
    resource->data.extended_irq.interrupt_count = 1;
    resource->data.extended_irq.interrupts[0] = p->start;
    }
    --


    \
     
     \ /
      Last update: 2008-04-25 20:49    [W:0.040 / U:29.988 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site