lkml.org 
[lkml]   [2008]   [Apr]   [24]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
DateThu, 24 Apr 2008 14:26:27 +1000
Subject[PATCH] Silence 'may be used uninitialized' warning in net/sunrpc/svc.c.
From(Tony Breeds)
Current kernels warn about:
net/sunrpc/svc.c: In function '__svc_create_thread':
net/sunrpc/svc.c:593: warning: 'oldmask.bits[0u]' may be used uninitialized in this function

As far as I can see oldmask will be initialised to something in each
case it's used.

Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
---
 net/sunrpc/svc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index 090af78..0e75a43 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -590,7 +590,7 @@ __svc_create_thread(svc_thread_fn func, struct svc_serv *serv,
 	struct svc_rqst	*rqstp;
 	int		error = -ENOMEM;
 	int		have_oldmask = 0;
-	cpumask_t	oldmask;
+	cpumask_t	uninitialized_var(oldmask);
 
 	rqstp = svc_prepare_thread(serv, pool);
 	if (IS_ERR(rqstp)) {
-- 
1.5.5.1

Yours Tony

  linux.conf.au    http://www.marchsouth.org/
  Jan 19 - 24 2009 The Australian Linux Technical Conference!



\
 
 \ /
  Last update: 2008-04-24 06:59    [W:0.254 / U:0.020 seconds]
©2003-2008 Jasper Spaans