lkml.org 
[lkml]   [2008]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/11] Add generic helpers for arch IPI function calls
    On Tue, Apr 22, 2008 at 08:50:17PM +0200, Jens Axboe wrote:
    > + data->csd.func(data->csd.info);
    > +
    > + spin_lock(&data->lock);
    > + cpu_clear(cpu, data->cpumask);
    > + WARN_ON(data->refs == 0);
    > + data->refs--;
    > + refs = data->refs;

    Probably a silly question, but what does data->refs do that
    cpus_empty(data->cpumask) wouldn't do? (as indeed ARM presently does.)

    --
    Russell King
    Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
    maintainer of:


    \
     
     \ /
      Last update: 2008-04-25 00:05    [W:0.291 / U:0.392 seconds]
    ©2003-2014 Jasper Spaans. Advertise on this site