lkml.org 
[lkml]   [2008]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 10/15] m68k: Some network drivers do not check the platform
    On Thu, 24 Apr 2008, Christoph Hellwig wrote:
    > On Thu, Apr 24, 2008 at 08:29:50PM +0200, Geert Uytterhoeven wrote:
    > > +++ b/drivers/net/macmace.c
    > > @@ -781,6 +781,9 @@ static int __init mac_mace_init_module(v
    > > {
    > > int err;
    > >
    > > + if (!MACH_IS_MAC)
    > > + return -ENODEV;
    > > +
    > > if ((err = platform_driver_register(&mac_mace_driver))) {
    > > printk(KERN_ERR "Driver registration failed\n");
    > > return err;
    >
    > This is rather odd. The whole point of the platform_driver
    > infrastructure is that the arch code only registers it if it's present
    > and then the driver can match for it. So the right fix here is to move
    > the platform_driver_register(&mac_mace_driver) into the mac arch setup

    I suppose you mean platform_*device*_register(), not
    platform_*driver*_register()?

    > code. A quick grep shows this is a quite common pattern for m68k
    > drivers.

    I know. That's work in progress.

    All these drivers predate the platform device framework and have been converted
    to this framework a while ago, without separating the actual platform drivers
    and platform devices.

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds


    \
     
     \ /
      Last update: 2008-04-24 20:53    [W:0.020 / U:60.428 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site