lkml.org 
[lkml]   [2008]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git patch] free_irq() fixes
Alan Cox wrote:
> Sparc32 had this and it was very ugly. However if you don't pass in the
> IRQ then people will store the irq value privately and things like
> request_irq can deal with numeric interrupts and the like as before while
> new interfaces for MSI can deal in MSI objects whatever they end up like.


Yes, and on a related note...

_Today_ drivers _already_ store the irq value privately, because they must:

Logic dictates they must do so because all other functions in the driver
do not have an 'irq' argument, but do need to call things (free_irq,
disable_irq) that take an irq number argument.

That is one of my key design objections to passing 'int' to an irq handler:

Every modern driver _must_ store the irq value anyway -- and typically
this is done automatically in struct device or struct pci_dev resources,
so the driver writer need not bother with storing it themselves.

Jeff






\
 
 \ /
  Last update: 2008-04-24 18:23    [W:2.734 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site