Messages in this thread Patch in this message |  | | | From | Rusty Russell <> | | Date | Wed, 23 Apr 2008 23:55:47 -0500 | | Subject | [PATCH 1/6] virtio: ignore corrupted virtqueues rather than spinning. | |
A corrupt virtqueue (caused by the other end screwing up) can have
strange results such as a driver spinning: just bail when we try to
get a buffer from a known-broken queue.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
drivers/virtio/virtio_ring.c | 5 +++++
1 file changed, 5 insertions(+)
diff -r cbd83e592664 drivers/virtio/virtio_ring.c
--- a/drivers/virtio/virtio_ring.c Fri Apr 04 22:42:47 2008 +1100
+++ b/drivers/virtio/virtio_ring.c Sat Apr 05 21:12:42 2008 +1100
@@ -184,6 +184,11 @@ static void *vring_get_buf(struct virtqu
START_USE(vq);
+ if (unlikely(vq->broken)) {
+ END_USE(vq);
+ return NULL;
+ }
+
if (!more_used(vq)) {
pr_debug("No more buffers in queue\n");
END_USE(vq);
|  |