lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xfs: #define out unused parameters of?xfs_bmap_add_free and xfs_btree_read_bufl
On Tue, Apr 22, 2008 at 09:32:38PM +0200, Denys Vlasenko wrote:
> On Tuesday 22 April 2008 20:28, Adrian Bunk wrote:
> > > Eh... I meant "no warnings about unused parameters" for fs/xfs/* only,
> > > not for the entire kernel. I filter out other warnings.
> > >
> > > I want to do it not as an excercise in perfectionism,
> > > but as means of making sure we do not waste stack
> > > passing useless parameters, which is important for xfs.
> >
> > That's not really maintainable,
>
> Why? Adding -Wunused -Wunused-parameter in fs/xfs/Makefile:
>
> EXTRA_CFLAGS += -I$(src) -I$(src)/linux-2.6 -funsigned-char
> #EXTRA_CFLAGS += -Wunused -Wunused-parameter
>
> and making a test build with it uncommented once in a while
> will reveal a bit of fallout, which is then fixed.
>...

The problem isn't in the Makefile, the problem are the ugly #ifdef's in
the code.

And for getting the stack problems fixed the effect is anyway by two
orders of magnitude too small, so there's no real gain in exchange.

> vda

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed



\
 
 \ /
  Last update: 2008-04-23 01:57    [W:0.395 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site