lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] move BUG_TABLE into RODATA
    Hi Jan.

    > --- linux-2.6.25/arch/x86/kernel/vmlinux_64.lds.S 2008-04-17 04:49:44.000000000 +0200
    > +++ 2.6.25-bug-table-rodata/arch/x86/kernel/vmlinux_64.lds.S 2008-03-04 11:14:13.000000000 +0100
    > @@ -19,7 +19,7 @@ PHDRS {
    > data PT_LOAD FLAGS(7); /* RWE */
    > user PT_LOAD FLAGS(7); /* RWE */
    > data.init PT_LOAD FLAGS(7); /* RWE */
    > - note PT_NOTE FLAGS(4); /* R__ */
    > + note PT_NOTE FLAGS(0); /* ___ */
    > }

    Is this intentional in this patch?


    > SECTIONS
    > {
    > @@ -40,16 +40,14 @@ SECTIONS
    > _etext = .; /* End of text section */
    > } :text = 0x9090
    >
    > + NOTES :text :note
    > +
    > . = ALIGN(16); /* Exception table */
    > __ex_table : AT(ADDR(__ex_table) - LOAD_OFFSET) {
    > __start___ex_table = .;
    > *(__ex_table)
    > __stop___ex_table = .;
    > - }
    > -
    > - NOTES :text :note
    > -
    > - BUG_TABLE :text
    > + } :text = 0x9090

    And I do not see the 0x9090 justified.
    Is this something to do with the fact that 0x90 equals NOP on x86?

    Rest looks good.

    Sam


    \
     
     \ /
      Last update: 2008-04-22 20:11    [W:0.024 / U:29.528 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site