Messages in this thread | | | Date | Tue, 22 Apr 2008 12:23:43 -0400 | From | Daniel Jacobowitz <> | Subject | Re: [Patch 6/6] Ptrace support for HARDWARE_WATCHPOINTS. |
| |
On Mon, Apr 21, 2008 at 05:40:11PM -0700, David Daney wrote: > +struct mips32_watch_regs { > + unsigned int num_valid; > + unsigned int reg_mask; > + unsigned int irw_mask; > + unsigned long watchlo[8]; > + unsigned int watchhi[8]; > +};
Please do not use long in new ptrace interfaces. Use either uint32_t or uint64_t as appropriate so that it doesn't depend on how the kernel or debugger was built.
-- Daniel Jacobowitz CodeSourcery
| |