lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: kgdb: fix optional arch functions and probe_kernel_*

* Jason Wessel <jason.wessel@windriver.com> wrote:

> >> Still. Do we need the set_fs() in there?
> >> __copy_from_user_inatomic() is a "__" uaccess function and hence
> >> shouldn't be running access_ok()?
> >
> > yeah, i guess that's true. Jason?
>
> In so far as the testing showed, it worked ok on the X86 arch with and
> without the set_fs(), but on ARM it is absolutely required. This
> means we have to decide to make arch specific or leave generic as it
> stands right now.

yeah, i guess so - it's no big issue as this isnt performance critical
in any way. Do you know which exact codepath/mechanism in ARM relies on
the set_fs() being there?

Ingo


\
 
 \ /
  Last update: 2008-04-22 15:11    [W:0.036 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site