lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] ALSA: Fix synchronize_irq() bugs, redundancies
    At Mon, 21 Apr 2008 19:34:19 -0400,
    Jeff Garzik wrote:
    >
    > free_irq() calls synchronize_irq() for you, so there is no need for
    > drivers to manually do the same thing (again). Thus, calls where
    > sync-irq immediately precedes free-irq can be simplified.
    >
    > However, during this audit several bugs were noticed, where free-irq is
    > preceded by a "irq >= 0" check... but the sync-irq call is not covered
    > by the same check.
    >
    > So, where sync-irq could not be eliminated completely, the missing check
    > was added.
    >
    > Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

    Thanks, I applied to ALSA tree now.


    Takashi


    \
     
     \ /
      Last update: 2008-04-22 12:59    [W:0.034 / U:31.356 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site