lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] UIO: generic platform driver
FromBen Nizette <>
DateTue, 22 Apr 2008 20:26:57 +1000

On Tue, 2008-04-22 at 11:52 +0200, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <Uwe.Kleine-Koenig@digi.com>
> ---
> Hello,
>
> This is the former patch 4/4 after some discussion.
>
> Open issues:
> - clock name "uio" isn't considered good by Russell King
> I don't have a better suggestion

I'd suggest it should be passed through from the platform code: only it
knows what it's going to be (and if indeed there's going to be one at
all). In fact, the lack-of-clock at the moment is fatal; it shouldn't
be IMO. For example, I don't need one in SMX.

> - some code could be shared with uio_smx.c
> I would address that in a seperate patch after this one hits mainline.

As I said before I'd prefer to keep my driver separate and standalone,
but you and HJK have expressed a wish for unification. If I get this
formally I'll consider myself outvoted and submit a patch to unify it
all when I submit my platform code (soon).

--Ben.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-04-22 12:29    [from the cache]
©2003-2010