Messages in this thread | | | Date | Mon, 21 Apr 2008 22:15:56 -0500 | From | Eric Sandeen <> | Subject | Re: [PATCH] xfs: do not pass unused params to xfs_flush_pages |
| |
Denys Vlasenko wrote: > Hi David, > > xfs_flush_pages() does not use some of its parameters, namely: > first, last and fiops. > > This patch removes these parameters from all callsites. > > Code size difference on 32-bit x86: > > text data bss dec hex filename > 390739 2748 1708 395195 607bb linux-2.6-xfs1-TEST/fs/xfs/xfs.o > 390567 2748 1708 395023 6070f linux-2.6-xfs2-TEST/fs/xfs/xfs.o > > Compile-tested only.
FWIW this one actually does not seem to reduce stack usage anywhere.
-Eric
| |