lkml.org 
[lkml]   [2008]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xfs: do not pass unused params to xfs_flush_pages
Denys Vlasenko wrote:
> Hi David,
>
> xfs_flush_pages() does not use some of its parameters, namely:
> first, last and fiops.
>
> This patch removes these parameters from all callsites.
>
> Code size difference on 32-bit x86:
>
> text data bss dec hex filename
> 390739 2748 1708 395195 607bb linux-2.6-xfs1-TEST/fs/xfs/xfs.o
> 390567 2748 1708 395023 6070f linux-2.6-xfs2-TEST/fs/xfs/xfs.o
>
> Compile-tested only.

FWIW this one actually does not seem to reduce stack usage anywhere.

-Eric


\
 
 \ /
  Last update: 2008-04-22 05:19    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site