lkml.org 
[lkml]   [2008]   [Apr]   [21]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: StackProtector Oopses - Re: 2.6.25-mm1
From Valdis.Kletnieks@vt ...
DateMon, 21 Apr 2008 22:04:27 -0400
On Mon, 21 Apr 2008 18:48:59 PDT, Arjan van de Ven said:

Typo alert?

> diff --git a/kernel/panic.c b/kernel/panic.c
> index c92c1e2..b4a6a05 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -351,7 +351,10 @@ static noinline void __stack_chk_test_func(void)
>  	}
>  #endif
>  	barrier();
> -	memset(&foo, 0, 2*sizeof(foo)); /* deliberate buffer overflow */
> +	if (current->stack_canary == *(((unsigned long *)&foo)+1))
> +		*(((unsigned long *)&foo)+1) = 0;
> +	else
> +		printk(KERN_ERR "No -ftack-protector canary found\n");
                                     -fstack?
>  	barrier();
>  }

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2008-04-22 04:07    [from the cache]
©2003-2008