[lkml]   [2008]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [git patches] ISDN cleanups (modularization prep) (was: ISDN testing)
(Let's change the subject back to what it was :-)

Jeff Garzik wrote:
> Frans Pop wrote:
>> But when I tried to modprobe hisax, I got:
>> # modprobe hisax
>> FATAL: Module hisax not found.
>> Cause seems to be:
>> # depmod -a
>> WARNING: Module
>> /lib/modules/2.6.25-isdn/kernel/drivers/isdn/hisax/hisaxdiva.ko ignored,
>> due to loop WARNING: Module
>> /lib/modules/2.6.25-isdn/kernel/drivers/isdn/hisax/libhisax.ko ignored,
>> due to loop WARNING: Loop
>> detected: /lib/modules/2.6.25-isdn/kernel/drivers/isdn/hisax/hisax.ko
>> needs libhisax.ko which needs hisax.ko again!
>> WARNING: Module
>> /lib/modules/2.6.25-isdn/kernel/drivers/isdn/hisax/hisax.ko ignored, due
>> to loop
> Yeah, that's what my patchset does -- splits the "hisax" driver into
> multiple smaller drivers. Thus, "modprobe hisax" produces the results
> that you are seeing.

Hmmm. Isn't that going to break things for existing users?

For example, I currently have this in /etc/modprobe.d/hisax to get the two
cards to work correctly:
options hisax type=9,11 protocol=2,2 irq=10 io=0x398

This effectively translates to:
- ITK card: type=9 protocol=2 irq=10 io=0x398
- Diva card: type=11 protocol=2

To what would I have to change this?

I suspect there will at least have to be a major update in Documentation to
tell people how options should now be set.

> You'll need to determine which newly-created kernel module applies to
> your hardware. Let me know if you need help with that. The new drivers
> should be in /lib/modules/2.6.25-isdn/kernel/drivers/isdn/hisax/
> provided that you enabled them in the kernel configuration.

I think that I have the correct config (unset options omitted):
# ISDN feature submodules
# ISDN4Linux hardware drivers
# Passive cards
# D-channel protocol features
# HiSax supported cards

Note that HISAX_16_3 and HISAX_IX1MICROR2 are y/n config options; making
those modular is not allowed.

This results in the following modules under drivers/isdn:
hisaxdiva.ko hisax.ko libhisax.ko

So AFAICT, I should still be loading hisax for the ITK card.

Also, I doubt that depmod is supposed to fail like the way I saw. Seems to
me that the "loop" errors during depmod are the cause of the modules not
being loadable.
Note that 'modprobe hisaxdiva' fails with the exact same message as for
hisax and that depmod even explicitly says that the modules are "ignored"!


 \ /
  Last update: 2008-04-21 22:23    [W:0.076 / U:3.520 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site