lkml.org 
[lkml]   [2008]   [Apr]   [21]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
DateMon, 21 Apr 2008 16:06:00 +0200
FromTakashi Iwai <>
SubjectRe: 2.6.25-mm1
At Fri, 18 Apr 2008 21:29:34 -0700,
Andrew Morton wrote:
> 
> > 
> > Cool things there:
> > 
> > +#ifdef CONFIG_DEBUG_PAGEALLOC
> > +	/* Well, CONFIG_DEBUG_PAGEALLOC makes the sound horrible. Lets
> > alert */
> > +	printk(KERN_WARNING
> > +	       "PCSP: Warning, CONFIG_DEBUG_PAGEALLOC is enabled!\n"
> > +	       "You have to disable it if you want to use the PC-Speaker
> > "
> > +	       "driver.\n"
> > +	       "Unless it is disabled, enjoy the horrible, distorted "
> > +	       "and crackling noise.\n");
> > +#endif
> 
> heh.
> 
> CONFIG_DEBUG_PAGEALLOC is a very heavy consumer of CPU cycles.  I'm not
> surprised that it would whack what I presume to be a very latency-sensitive
> driver.

We can add simply a dependncy to Kconfig if this really matters.


Takashi

---
diff -r e8f61dd0b153 sound/drivers/Kconfig
--- a/sound/drivers/Kconfig	Thu Apr 17 17:58:34 2008 +0200
+++ b/sound/drivers/Kconfig	Mon Apr 21 16:06:09 2008 +0200
@@ -7,6 +7,7 @@
 config SND_PCSP
 	tristate "Internal PC speaker support"
 	depends on X86_PC && HIGH_RES_TIMERS
+	depends on !DEBUG_PAGEALLOC
 	help
 	  If you don't have a sound card in your computer, you can include a
 	  driver for the PC speaker which allows it to act like a primitive

\
 
 \ /
  Last update: 2008-04-21 16:09    [from the cache]
©2003-2008