Messages in this thread |  | | | Date | Sun, 20 Apr 2008 00:22:29 -0400 | | From | "H. Peter Anvin" <> | | Subject | Re: [PATCH 2/4] x86: remove unused code and data in nexgen.c | |
Dmitri Vorobiev wrote:
> Nobody calls the function nexgen_init_cpu(), therefore it
> can be removed. The variable nexgen_cpu_dev is used only by
> this function, so this patch removes useless data as well.
>
> This patch was build-tested using defconfigs for i386 and x86_64.
> It also survived a few randconfig instances for i386. Runtime
> tests were performed by booting 32-bit and 64-bit x86 boxen up to
> the shell prompt.
NAK. This is broken.
The reason nexgen_cpu_dev is unreferenced is because the file is missing
a cpu_vendor_dev_register(), which should be added.
-hpa
|  |