lkml.org 
[lkml]   [2008]   [Apr]   [2]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 02 Apr 2008 00:14:32 -0700 (PDT)
SubjectRe: + sparc32-delete-bogus-js-rtc-records.patch added to -mm tree
FromDavid Miller <>
From: akpm@linux-foundation.org
Date: Mon, 31 Mar 2008 16:51:38 -0700

> Subject: sparc32: delete bogus js-rtc records
> From: David Brownell <david-b@pacbell.net>
> 
> While looking at the legacy RTC drivers in the drivers/char directory, I
> noticed what looks like bogus entry for SPARC32 systems: JS_RTC, which seems
> to rely on a non-existent js-rtc file.  Just delete it.
> 
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

It is actually used.  Look at what the Makefile is doing:

> diff -puN drivers/char/Makefile~sparc32-delete-bogus-js-rtc-records drivers/char/Makefile
> --- a/drivers/char/Makefile~sparc32-delete-bogus-js-rtc-records
> +++ a/drivers/char/Makefile
> @@ -109,9 +109,6 @@ obj-$(CONFIG_TCG_TPM)		+= tpm/
> 
>  obj-$(CONFIG_PS3_FLASH)		+= ps3flash.o
> 
> -obj-$(CONFIG_JS_RTC)		+= js-rtc.o
> -js-rtc-y = rtc.o
> -
>  # Files generated that shall be removed upon make clean
>  clean-files := consolemap_deftbl.c defkeymap.c

It's building rtc.c into js-rtc.o, and if CONFIG_JS_RTC is set that
gets linked into the kernel.

Andrew, please drop this one.

Thanks.


\
 
 \ /
  Last update: 2008-04-02 09:17    [from the cache]
©2003-2008