lkml.org 
[lkml]   [2008]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/15] ARM minor irq handler cleanups
Russell King wrote:
> On Fri, Apr 18, 2008 at 07:22:45PM -0400, Jeff Garzik wrote:
>> Avoid confusion by /not/ passing an unused pointer to
>> arm_rtc_interrupt()
>>
>> This change's main purpose is to prepare for the patchset in
>> jgarzik/misc-2.6.git#irq-remove, that explores removal of the
>> never-used 'irq' argument in each interrupt handler.
>
> I don't see how these two things are connected. Yes, it's true that
> this RTC driver doesn't use 'dev_id' but that's an entirely separate
> issue to removing the 'int irq' argument.
>
> As I see it, this change is just unnecessarily adding to your workload
> for this patch set.

The added workload came from confusion created when I reviewed the code :)

Therefore I considered it better to have to less confusing version of
the code in my tree for future reviews, and ideally have the less
confusing version of the code in upstream as well.

I can remove the boilerplate paragraph from the patch description, if
that's your main complaint.

Jeff





\
 
 \ /
  Last update: 2008-04-19 10:31    [from the cache]
©2003-2011 Jasper Spaans