[lkml]   [2008]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 01/15] ARM minor irq handler cleanups
    On Fri, Apr 18, 2008 at 07:22:45PM -0400, Jeff Garzik wrote:
    > Avoid confusion by /not/ passing an unused pointer to
    > arm_rtc_interrupt()
    > This change's main purpose is to prepare for the patchset in
    > jgarzik/misc-2.6.git#irq-remove, that explores removal of the
    > never-used 'irq' argument in each interrupt handler.

    I don't see how these two things are connected. Yes, it's true that
    this RTC driver doesn't use 'dev_id' but that's an entirely separate
    issue to removing the 'int irq' argument.

    As I see it, this change is just unnecessarily adding to your workload
    for this patch set.

    Russell King
    Linux kernel 2.6 ARM Linux -
    maintainer of:

     \ /
      Last update: 2008-04-19 10:25    [W:0.018 / U:66.984 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site