lkml.org 
[lkml]   [2008]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ofa-general] Re: [GIT PULL] please pull infiniband.git
On Sat, 19 Apr 2008, Roland Dreier wrote:
| > drivers/built-in.o: In function `ipath_init_one':
| > ipath_driver.c:(.devinit.text+0x1e5bc): undefined reference to `ipath_init_iba7220_funcs'

Yes, that issue should be fixed. Our preference was to not build
if it wouldn't work. We'd have to add the conditional check at
the function setup routines.


| I also removed the dependency on HT_IRQ || PCI_MSI in the Kconfig, since
| the iba7220 support should work without it. I know we discussed this
| before, but looking closer at the code, the dependency seems pointless
| to me, since it's still possible to build a driver that doesn't work if
| a particular system needs, say HT_IRQ, and the user selects PCI_MSI.
| And since iba7220 doesn't need either, we might as well let people build
| that.
|
| If this is OK with everyone, I will merge this with a proper changelog.

At this point, I guess I'd agree. We've added checks for "no interrupt"
after the driver is loaded, so I guess that covers the issue well
enough.

Dave Olson
dave.olson@qlogic.com


\
 
 \ /
  Last update: 2008-04-19 17:23    [W:0.044 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site