Messages in this thread | | | Date | Fri, 18 Apr 2008 18:17:41 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 01/15] ARM minor irq handler cleanups |
| |
On Fri, 18 Apr 2008 20:21:07 -0400 Jeff Garzik <jeff@garzik.org> wrote:
> Andrew Morton wrote: > > On Fri, 18 Apr 2008 19:22:45 -0400 (EDT) > > Jeff Garzik <jeff@garzik.org> wrote: > > > >> Avoid confusion by /not/ passing an unused pointer to > >> arm_rtc_interrupt() > >> > >> This change's main purpose is to prepare for the patchset in > >> jgarzik/misc-2.6.git#irq-remove, that explores removal of the > >> never-used 'irq' argument in each interrupt handler. > > > > #irq-remove doesn't seem to be included in the #ALL branch which > > I'm grabbing? > > I certainly welcome the exposure....... but it would be a huge pain for > you IMO because of the constant breakage. >
wow.
1084 files changed, 2363 insertions(+), 1934 deletions(-)
I didn't realise you'd changed all the interrupt handlers too. Good luck with that :)
Is it a flag day or do we have a migration plan? I'd have thought that we could do a request_irq_new(irqreturn_t (*)(void *d)) and keep things compatible?
<checks>
Actually, that tree applies reasonably sanely to the full -mm lineup. There are rejects of course, but they're easily fixed and a lot are due to file motion which git will handle anyway,
The bigger problem is newly-added irq handlers which your patch doesn't know about:
y:/usr/src/25> grep '^+.*request_irq[(]' patches/*.patch | wc -l 74
If we had a migration plan (ie: request_irq_new(), above) then this of course wouldn't be a problem.
| |