lkml.org 
[lkml]   [2008]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 12/15] [MIPS] pmc-sierra/msp71xx/msp_hwbutton.c: minor irq handler cleanups
    Date
    - remove always-true test

    - neaten request_irq() indentation

    This change's main purpose is to prepare for the patchset in
    jgarzik/misc-2.6.git#irq-remove, that explores removal of the
    never-used 'irq' argument in each interrupt handler.

    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
    ---
    arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c | 5 +----
    1 files changed, 1 insertions(+), 4 deletions(-)

    diff --git a/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c b/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c
    index ab96a2d..11769b5 100644
    --- a/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c
    +++ b/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c
    @@ -126,9 +126,6 @@ static irqreturn_t hwbutton_handler(int irq, void *data)
    struct hwbutton_interrupt *hirq = data;
    unsigned long cic_ext = *CIC_EXT_CFG_REG;

    - if (irq != hirq->irq)
    - return IRQ_NONE;
    -
    if (CIC_EXT_IS_ACTIVE_HI(cic_ext, hirq->eirq)) {
    /* Interrupt: pin is now HI */
    CIC_EXT_SET_ACTIVE_LO(cic_ext, hirq->eirq);
    @@ -164,7 +161,7 @@ static int msp_hwbutton_register(struct hwbutton_interrupt *hirq)
    *CIC_EXT_CFG_REG = cic_ext;

    return request_irq(hirq->irq, hwbutton_handler, IRQF_DISABLED,
    - hirq->name, (void *)hirq);
    + hirq->name, hirq);
    }

    static int __init msp_hwbutton_setup(void)
    --
    1.5.4.1


    \
     
     \ /
      Last update: 2008-04-19 01:29    [W:0.020 / U:1.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site