Messages in this thread | | | Date | Wed, 16 Apr 2008 12:58:55 +0200 | From | Pavel Machek <> | Subject | Re: hci_usb: remove macro code obfuscation |
| |
On Wed 2008-04-16 13:51:37, Vitaliy Ivanov wrote: > On Wed, Apr 16, 2008 at 1:42 PM, Pavel Machek <pavel@ucw.cz> wrote: > > > > I had trouble figuring out what the code does. atomic_inc/dec > > management is actually pretty simple, but it is needlessly obfuscated > > with macros. Fix that. > > > > Signed-off-by: Pavel Machek <pavel@suse.cz> > > > > I had trouble figuring out what the code does. atomic_inc/dec > > management is actually pretty simple, but it is needlessly obfuscated > > with macros. Fix that. > > > > Signed-off-by: Pavel Machek <pavel@suse.cz> > > > Got it from the first time;) > > Do you think that now code looks better? As for me it's not...
Yes. Hiding & operator deep inside macro is evil for one thing. Plus it is no longer clear what the code does with the macros in there. Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |