![]() | ||||||||||
Messages in this thread |
On Tue 2008-04-15 16:25:29, SL Baur wrote: > On 4/15/08, Pavel Machek <pavel@ucw.cz> wrote: > > Cleanup gart handling on amd64 a bit: move common code into > > enable_gart_translation , and use symbolic register names where > > appropriate. > > > > Signed-off-by: Pavel Machek <pavel@suse.cz> > > Which source tree is this patch against? I'm looking at Linus > latest and I don't see the AMD64_* constants defined in the > same place. x86 tree, hopefully. > Other reviewer comments:> The casting between struct pci_dev * and u64 is kind of ugly, > I presume the reason for the narrowing casts in the block of > code you moved is documented somewhere. Where am I doing that? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | |||||||||
| Last update: 2008-04-16 10:17 [from the cache] ©2003-2008 | ||||||||||