Messages in this thread |  | | | Date | Wed, 16 Apr 2008 12:19:47 -0400 | | From | Masami Hiramatsu <> | | Subject | Re: [PATCH -mm] relayfs: support larger relay buffer |
| |
Hi Tom,
Tom Zanussi wrote: > On Tue, 2008-04-15 at 11:27 -0400, Masami Hiramatsu wrote: >> Use vmalloc() and memset() instead of kcalloc() to allocate a page* array >> when the array size is bigger than one page. This enables relayfs to support >> bigger relay buffers than 64MB on 4k-page system, 512MB on 16k-page system. >> >> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com> >> --- >> This is useful for a 64-bit system which has a plenty of memory (tens of >> giga bytes) and a large kernel memory space. >> >> I tested it on x86-64 and ia64. >> > > Hi, > > It looks ok to me, but it might be a little cleaner and avoid some > duplication if you add the new code as a couple of functions instead. > Just a suggestion...
Sure, that is a good idea, I'll renew my patch. Thank you,
-- Masami Hiramatsu
Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division
e-mail: mhiramat@redhat.com
|  |