lkml.org 
[lkml]   [2008]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] Make defencive checks around PFN values registered for memory usage

* Mel Gorman <mel@csn.ul.ie> wrote:

> + if (*start_pfn > max_sparsemem_pfn) {
> + mminit_debug_printk(MMINIT_VERIFY, "pfnvalidation",
> + "Start of range %lu -> %lu exceeds SPARSEMEM max %lu\n",
> + *start_pfn, *end_pfn, max_sparsemem_pfn);

small request: please emit a WARN_ON_ONCE() as well, so that
kerneloops.org (and automated test setups) picks it up.

> + mminit_debug_printk(MMINIT_VERIFY, "pfnvalidation",
> + "End of range %lu -> %lu exceeds SPARSEMEM max %lu\n",
> + *start_pfn, *end_pfn, max_sparsemem_pfn);

ditto - all errors should be fixed up and we should try to continue as
far as possible, but emitting a WARN_ON_ONCE() will be very useful in
making sure people notice the warning.

Ingo


\
 
 \ /
  Last update: 2008-04-16 16:05    [W:0.271 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site